-
-
Notifications
You must be signed in to change notification settings - Fork 431
Expand ECN support #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand ECN support #222
Conversation
Yeah, waiting for the next release sounds like a good idea. |
Codecov Report
@@ Coverage Diff @@
## master #222 +/- ##
==========================================
+ Coverage 74.82% 74.84% +0.01%
==========================================
Files 24 24
Lines 6150 6150
==========================================
+ Hits 4602 4603 +1
+ Misses 1548 1547 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #222 +/- ##
=========================================
Coverage ? 74.82%
=========================================
Files ? 24
Lines ? 6150
Branches ? 0
=========================================
Hits ? 4602
Misses ? 1548
Partials ? 0
Continue to review full report at Codecov.
|
65579eb
to
2d3e596
Compare
libc's CMSG macros got built out to many more platforms. There may remain some obscure platforms where this will still fail to build, but we can account for them as they show up in practice.
I think this is ready for re-review and merge. If the macos inconsistencies are representative, there'll probably be additional tweaks necessary for other platforms, but only minor ones, and their necessity will be immediately obvious when socket configuration fails. |
libc's CMSG macros got built out to many more platforms. There may remain some obscure platforms where this will still fail to build, but we can account for them as they show up in practice.
Note that some bugs remain in the new libc bindings, so we may want to defer merging this until rust-lang/libc#1235 shows up in a release.