feat: Faster UDP/IO on Apple platforms #1993
Draft
+1,637
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We found there wasn't much performance benefit, and was considerable difficulty taking advantage of, |
Ralith
reviewed
Sep 20, 2024
| fn main() { | ||
| // Generate the bindings for Apple's private `recvmsg_x` from | ||
| // https://github.com/apple-oss-distributions/xnu/blob/main/bsd/sys/socket.h. | ||
| let bindings = bindgen::Builder::default() |
There was a problem hiding this comment.
Bindgen is a pretty big and unstable dependency. Would it be simpler to commit the generated bindings?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress.
Question to the quinn maintainers: Is there interest in seeing TX support via
sendmsg_x? (Sincesendmmsgwas removed.)CC @mxinden