fix(.github/android): pass matrix.target and increase api to v26 #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
approved these changes
Aug 22, 2024
mxinden
changed the title
djc
reviewed
Aug 23, 2024
mxinden
commented
Aug 23, 2024
When extracting the emulator script into a separate file, the `matrix.target` substitution wasn't replaced with an environment variable. Follow-up to quinn-rs#1950.
`ecn_*` unit tests are failing with any Android API version < v26 with:
```
2024-08-22T14:41:30.636494Z WARN quinn_udp: sendmsg error: Os { code: 22, kind: InvalidInput, message: "Invalid argument" }, Transmit: { destination: 127.0.0.1:50196, src_ip: None, enc: Some(Ect0), len: 5, segment_size: None }
```
djc
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When extracting the emulator script into a separate file, the
matrix.targetsubstitution wasn't replaced with an environment variable.Follow-up to #1950.
Also the
ecn_*unit tests are failing with any Android API version < v26 with: