Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gorry's editorial comments #296

Merged
merged 3 commits into from
May 31, 2024
Merged

Gorry's editorial comments #296

merged 3 commits into from
May 31, 2024

Conversation

mirjak
Copy link
Contributor

@mirjak mirjak commented May 21, 2024

Thanks!

gorryfair
gorryfair approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@gorryfair gorryfair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

ianswett
ianswett reviewed May 29, 2024
View reviewed changes
Copy link
Collaborator

@ianswett ianswett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion and one Question, but otherwise LG

draft-ietf-quic-ack-frequency.md Outdated
@@ -145,7 +145,7 @@ endpoint performance in the following ways:
- Sending UDP datagrams is very CPU intensive on some platforms. A data
receiver can decrease its CPU usage by reducing the number of
acknowledgement-only packets sent. Experience shows that this
reduction can be critical for high bandwidth connections.
reduction can be critical for high-rate connections.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure what this means, but I can see why bandwidth may not be exactly correct. What about "high packet rate connections."?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packet rate is fine also

draft-ietf-quic-ack-frequency.md Outdated Show resolved Hide resolved
@ianswett ianswett merged commit 9bf1487 into main May 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gorryfair gorryfair gorryfair approved these changes

@ianswett ianswett ianswett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mirjak @gorryfair @ianswett