Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to request one ack per rtt #278

Merged
merged 4 commits into from
Mar 4, 2024
Merged

how to request one ack per rtt #278

merged 4 commits into from
Mar 4, 2024

Conversation

mirjak
Copy link
Contributor

@mirjak mirjak commented Mar 1, 2024

fixes #227

Max Ack Delay.
into the current congestion window.
Alternatively, a sender can send an IMMEDIATE_ACK frame if no acknowledgement
has been receive for more than one round trip time. Although if the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/receive/received/

Copy link
Contributor

@gorryfair gorryfair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see correction.

Copy link
Member

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The three options seem right.

draft-ietf-quic-ack-frequency.md Outdated Show resolved Hide resolved
when there are ack-eliciting packets in flight.
can utilize the extension in this draft to request a receiver
to send an acknowledgment at least once per round trip,
when there are ack-eliciting packets in flight, the following ways:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the colon mean that a list follows?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it has to follow a list...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems weird to me to use the colon this way, but also is there a word missing, like "in the following ways"?

@mirjak mirjak merged commit 3900129 into main Mar 4, 2024
3 checks passed
@mirjak mirjak deleted the mirjak-patch-42 branch February 6, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't recommend sending one IMMEDIATE_ACK per RTT
4 participants