support ff range queries on json fields #2456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSeitz
force-pushed
the
str_fast_field_range_query2
branch
from
19f4077
to
a2ea1ff
Compare
PSeitz
force-pushed
the
str_fast_field_range_query2
branch
from
a2ea1ff
to
e964e9d
Compare
PSeitz
force-pushed
the
str_fast_field_range_query2
branch
from
e964e9d
to
ba33a2a
Compare
PSeitz
force-pushed
the
str_fast_field_range_query2
branch
4 times, most recently
from
6a0e9a1
to
639f67d
Compare
PSeitz
force-pushed
the
str_fast_field_range_query2
branch
from
639f67d
to
b943add
Compare
fulmicoton
approved these changes
Jul 31, 2024
philippemnoel
pushed a commit
to paradedb/tantivy
that referenced
this pull request
Aug 31, 2024
* support ff range queries on json fields * fix term date truncation * use inverted index range query for phrase prefix queries * rename to InvertedIndexRangeQuery * fix column filter, add mixed column test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support ff range queries on json fields. Supported json field types are u64, i64, f64, term and date.
Fixes date truncation issue in Term, where DateTime was truncated to seconds precision unconditionally, but we only want to apply that truncation on the inverted index.
It's a footgun that date needs to truncated when creating the Term. A proper fix depends on #2366
Changes
PhrasePrefixQueryto always use the inverted index range queryTODO: