Skip to content

Measure GRPC server metrics at the HTTP level and client metrics at the service level #5786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rdettai
Copy link
Collaborator

@rdettai rdettai commented Jun 5, 2025

Description

Currently, we have metrics called grpc_xxx that actually take measurement at the service level:

  • this makes it hard to measure bytes transferd
  • it sometimes measures calls that actually don't use the network stack, which makes the "grpc" name confusing.

This PR attemps to steamline the metrics:

  • grpc_x metrics are now recorded by an http level layer on GRPC servers only
  • we introduce service_x metrics that are recorded in clients only but use the "kind" label to distinguish "local" vs "remote" invocations.

How was this PR tested?

TODO

@rdettai
Copy link
Collaborator Author

rdettai commented Jun 5, 2025

TODO:

  • tests
  • verify that the client layers are properly registered (never attached to server stacks)
  • see if we can somehow improve GrpcMetricsLayer to also track streams
  • see if we can somehow improve GrpcMetricsLayer to also track compression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant