Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix context range precision gap #123

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

ddelemeny
Copy link
Contributor

When looking backwards on a searchAfter request, createContextTimerange creates a range which does not contain the searchAfter target timestamp row.timeEpochNs because of truncated precision.

This PR does the following :

  • offset the higher bound by 1 Ms to make sure that the target timestamp is within the bounds after truncation.
  • add a test to check that scenario

@ddelemeny ddelemeny force-pushed the ddelemeny/fix-context-range branch 2 times, most recently from 57ff6ae to 02c9a22 Compare April 25, 2024 19:24
@ddelemeny ddelemeny merged commit 8afe6fb into main Apr 25, 2024
2 checks passed
@ddelemeny ddelemeny deleted the ddelemeny/fix-context-range branch May 20, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants