Skip to content

projectured: update source.txt to use tagged-git instead of branched-git #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

attila-lendvai
Copy link
Contributor

No description provided.

@quicklisp
Copy link
Owner

Why?

@attila-lendvai
Copy link
Contributor Author

tags provide more freedom to move them around. if the history of branches are overwritten, then it can cause headaches when people pull on them.

@quicklisp
Copy link
Owner

So the "quicklisp" tag may move around?

@attila-lendvai
Copy link
Contributor Author

yes, that's the plan. because there'll be a major reorg that will rewrite the history of the master branch, and rename master to something historical. when a new stable state is reached, then moving the tag feels more natural than rewriting the quicklisp branch.

but i can be easily convinced why not to do this if there are any reasons.

@quicklisp
Copy link
Owner

If I have a repo checked out with a tag, what do I need to do to follow a tag that has moved?

@attila-lendvai
Copy link
Contributor Author

to push:

$ git push -f origin taggg
Counting objects: 1, done.
Writing objects: 100% (1/1), 163 bytes | 0 bytes/s, done.
Total 1 (delta 0), reused 0 (delta 0)
To /tmp/origin
 + f54c750...7e88e2e taggg -> taggg (forced update)

to pull:

$ git tag -ln
taggg           tag test banan
$ git pull --tags
remote: Counting objects: 1, done.
remote: Total 1 (delta 0), reused 0 (delta 0)
Unpacking objects: 100% (1/1), done.
From /tmp/origin
 - [tag update]      taggg      -> taggg
Already up-to-date.
$ git tag -ln
taggg           asdfffff tag desc

@attila-lendvai
Copy link
Contributor Author

note: fetch --tags also works the same as pull. i've created a PR for the ql-controller repo to add it.

@fiddlerwoaroof
Copy link

Maybe it'd be better to expect a tag of the format quicklisp-<id> where the lexically greatest is pulled as the current version? That way, you don't have to move tags around and can keep track of all the released commits.

@attila-lendvai
Copy link
Contributor Author

that'd be unnecessary complexity, i think.

tags in version control systems are labels to denote a specific revision. and that's exactly what we need here: a symbolic constant that quicklisp can refer to, and that the project authors can move around freely to whichever revision they deem appropriate for the next quicklisp release.

and if git tags happen to give some headaches, then they need to be addressed/kludged (i don't think that is the case).

@attila-lendvai
Copy link
Contributor Author

FTR, this is that PR in ql-controller: quicklisp/quicklisp-controller#11

@ryukinix
Copy link

ryukinix commented Nov 6, 2017

I think using git tag based releases is a good thing.

@quicklisp quicklisp closed this Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants