Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Move quickemu_conf manual to section 5 #1454

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

dridi
Copy link
Contributor

@dridi dridi commented Sep 12, 2024

Description

As a configuration reference, it does not belong in section 1. To facilitate the implementation and avoid repetition between sections, pandoc make rules were simplified to accommodate the change.

I was planning to study quickemu and bring it to Fedora if it works with my use cases. I started with the documentation and next thing you know a yak shows up in a manual and I needed to get it out of the way to resume progress so I shaved it right away.

Type of change

  • Breaking change (technically changing the installation layout)
  • Packaging (updates the packaging)
  • Documentation (updates the documentation)

Checklist:

  • I have performed a self-review of my code
  • I have tested my code in common scenarios and confirmed there are no regressions
  • I have added comments to my code, particularly in hard-to-understand sections
  • I have made corresponding changes to the documentation (remove if no documentation changes were required)

On the last point, I technically made corresponding changes outside of the documentation.

I don't think this change needs new comments, but I'll let you be the judge of that.

This removes a --standalone duplicate and counter-productive
indirections like $(MANSECTION) because it prevents having more
than one and docs/Makefile hardcodes the section anyway.
Copy link
Contributor

@philclifford philclifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. One slight concern is that Section 1 is by default searched before 5, so future changes might get overlooked if users do not explicitly select section 5 and have got an outdated copy left over in section 1. We should consider preemptively removing the old copy.

Copy link
Contributor

@philclifford philclifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny omission: (ignore the pandoc upgrade ;-) )

diff --git a/docs/quickemu_conf.5 b/docs/quickemu_conf.5
index ca950b1..d07e135 100644
--- a/docs/quickemu_conf.5
+++ b/docs/quickemu_conf.5
@@ -1,6 +1,6 @@
-.\" Automatically generated by Pandoc 3.3
+.\" Automatically generated by Pandoc 3.4
 .\"
-.TH "QUICKEMU_CONF" "1" "August 2, 2024" "quickemu_conf" "Quickemu Configuration Manual"
+.TH "QUICKEMU_CONF" "5" "August 2, 2024" "quickemu_conf" "Quickemu Configuration Manual"
 .SH NAME
 quickemu_conf \- Options and parameters in the quickemu <vm>.conf
 .SH DESCRIPTION

Please either run the make clean ; make to rebuild or
tweak quickemu_conf.5 so it says it is in Section 5 not 1.

@dridi
Copy link
Contributor Author

dridi commented Oct 2, 2024

This change belongs in the second commit. Do you prefer a force-push upfront or an additional commit to squash into the second one afterwards?

@philclifford
Copy link
Contributor

I'd prefer a forced push. I'm happy either way and appreciative of the contribution and consideration.

Where it technically belongs... With the new make rules for pandoc, it's
actually much easier to manage manuals in several sections without much
overhead.
@dridi
Copy link
Contributor Author

dridi commented Oct 3, 2024

I should have known better, after all I edited the .1 files right off the bat.

@flexiondotorg flexiondotorg merged commit 84595dc into quickemu-project:master Oct 4, 2024
4 checks passed
@dridi dridi deleted the quickemu_conf.5 branch October 4, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants