fix: pin macos-13 as os for building amd64 binary #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch! Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been looking at your CI build config because I am currently trying to figure out a multi-arch go build that uses libfido2 and spotted one subtle issue that could affect the amd64 build of future versions in this project.
The config uses "macos-latest" os for building the x86_64 version which currently defaults to "macos-14". This os seems to create only arm64 binaries (I don't know too much about mac architecture). It seems that at the time of the last release the default was "macos-12" (checked the wayback machine on the github docs). So the increase of the default would probably cause the x86_64 binaries in the next release to actually be arm64. Pinning the version to "macos-13" seems to fix that.