Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web-console): file settings not being passed to API #271

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

insmac
Copy link
Contributor

@insmac insmac commented Mar 26, 2024

Fixes #270

Since CSV Import allows importing files with the same names multiple times, we've stopped using filenames as their identifier, which means this is what we check against when updating their settings when user changes them. The following bug was a leftover from the older times.

Steps to replicate:

  1. Upload the file attached in the original issue.
  2. Select "Force header" in the Settings drawer to.
  3. The table should be created with proper column names, inferred from the CSV file header.

@javier javier self-assigned this Mar 26, 2024
Copy link

@javier javier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bluestreak01 bluestreak01 merged commit 7544cdd into main Mar 26, 2024
2 checks passed
@bluestreak01 bluestreak01 deleted the web-console/fix-settings-payload branch March 26, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Headers toggle ignored when importing
3 participants