Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web-console): Fix issues with Run button in editor gutter #257

Merged
merged 6 commits into from
Jan 5, 2024

Conversation

insmac
Copy link
Contributor

@insmac insmac commented Dec 20, 2023

This PR addresses two issues:

  1. By dynamically adjusting the left gutter (the space with line numbers and decoration glyphs) it ensures the green "Run" button stays in a fixed position no matter how many lines in the editor there are. When the line number changes in digit count (i.e. from 99 to 100), gutter width expands or contracts accordingly to ensure visual consistency.
  2. The way the green "Run" (play) is rendered has been changed to ensure it always looks the same no matter the browser and operating system.

Fixes #251

@insmac insmac added the web-console Issues relevant to "web-console" package label Dec 20, 2023
@bluestreak01 bluestreak01 merged commit bcc9b81 into main Jan 5, 2024
1 check passed
@bluestreak01 bluestreak01 deleted the web-console/fix-run-position branch January 5, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
web-console Issues relevant to "web-console" package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gutter icons can overlap
2 participants