-
Notifications
You must be signed in to change notification settings - Fork 19
Stability changes for version 5.0.0 #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amunra
wants to merge
24
commits into
main
Choose a base branch
from
v5
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR is about introducing stability changes targeting the release of version 5.0.0.
Task list
is only suggested for TCP and we advise "auto" for HTTP.
max_line_len
from/settings
(see point above).line_sender_buffer_column_f64_arr_row_major
(we will use this from Python).You mentioned that these are slower than the equivalent Rust
ndarray
APIs.ArrayError
code. These should be consolidated:ArrayHasTooManyDims
ArrayViewError
ArrayWriteToBufferError
data and strides.
length, and assumes default strides (calling
_f64_arr_row_major
).(cd questdb-rs && cargo doc --open)
E.g.: warning: unresolved link to
Sender::new_buffer_with_max_name_len
.version of QuestDB supports arrays.
My guess is that it is going to be 8.4.0, but we need to confirm this.
(I've also added this todo to the Python client TODO list.)
against the
nd_arr
branch. We should also retain a CI test run that runsagainst an older version of QuestDB (e.g. 8.3.3) to ensure that we don't
introduce regressions against protocol version 1.
Tandem PR
See related
py-questdb-client
PR: questdb/py-questdb-client#108