Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mega tonne per yr #1081

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Add mega tonne per yr #1081

merged 3 commits into from
Dec 19, 2024

Conversation

JurekMueller
Copy link
Contributor

  • Adds unit MegaTONNE-PER-YR
  • Corrects ucumCode for TeraW-HR-PER-YR

@fkleedorfer
Copy link
Collaborator

Thanks for your submission! Please follow these easy steps to format the sources to allow the build to succeed: https://github.com/qudt/qudt-public-repo/wiki/Formatting-the-source-via-GitHub-Workflow

@fkleedorfer
Copy link
Collaborator

Apart from the formatting, this looks good to me.

fkleedorfer
fkleedorfer requested changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@fkleedorfer fkleedorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As soon as formatting is applied, this PR should be ok.

@JurekMueller
Copy link
Contributor Author

Thank you for your review. I have applied the formatting action now.

@fkleedorfer fkleedorfer merged commit 4930fc5 into qudt:main Dec 19, 2024
@fkleedorfer
Copy link
Collaborator

Darn, forgot about the Changelog. Would you mind making another PR adding the changes to the changelog under Added and Fixed headings, linking to your github profile as it was done in the changes leading up to the latest release?

@JurekMueller JurekMueller mentioned this pull request Dec 19, 2024
Merged
steveraysteveray pushed a commit that referenced this pull request Dec 19, 2024
@JurekMueller
Added changes of PR #1081 to changelog (#1083)
eca03d9 
* Added changelog for last PR

* Apply formatting rules

---------

Co-authored-by: JurekMueller <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkleedorfer fkleedorfer fkleedorfer approved these changes

@steveraysteveray steveraysteveray Awaiting requested review from steveraysteveray steveraysteveray is a code owner

@ralphtq ralphtq Awaiting requested review from ralphtq ralphtq is a code owner

@jhodgesatmb jhodgesatmb Awaiting requested review from jhodgesatmb jhodgesatmb is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JurekMueller @fkleedorfer