Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix html page links #1078

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Fix html page links #1078

merged 3 commits into from
Dec 12, 2024

Conversation

steveraysteveray
Copy link
Collaborator

The latest version and previous version links were being generated incorrectly.

Copy link
Collaborator

@fkleedorfer fkleedorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we do not want vaem:revision triples, is that correct?

Instead of removing those we could change the publishing algorithm so we don't generate these suffixes?

But I don't have a horse in this race so... Your call

@steveraysteveray
Copy link
Collaborator Author

It would be cleaner to change the algorithm, but it lives inside the linkedmodels repository created by @ralphtq, and I try to avoid making changes to it. So, this temporary hack results in the correct links, but also results in the blank line at the top of the page that says: "This version: ". Removing that line would also require a change to lmdoc.

Bottom line, all this goes away with our new publishing code when it's ready. At that point, we could decide whether we want to restore the vaem:revision triples for any purpose.

@steveraysteveray steveraysteveray marked this pull request as ready for review December 12, 2024 19:23
@steveraysteveray steveraysteveray merged commit bdc2fef into main Dec 12, 2024
1 check passed
@steveraysteveray steveraysteveray deleted the srr-fix-metadata branch December 12, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants