Added Focal tversky loss #932
Open
+120
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qubvel
reviewed
Oct 5, 2024
There was a problem hiding this comment.
Hi @Aditi-Mhatre, thanks for adding a new loss function and thank you for adding a test!
I left some comments below, and can you please include the loss to the docs/? Thanks 🤗
| beta: float = 0.5, | ||
| gamma: float = 1.0, | ||
| ): | ||
| assert mode in {BINARY_MODE, MULTILABEL_MODE, MULTICLASS_MODE} |
There was a problem hiding this comment.
Please move the class docstring under __init__ similar to other losses
Comment on lines
+226
to
+236
| output_sum = torch.sum(output, dim=dims) | ||
| target_sum = torch.sum(target, dim=dims) | ||
| difference = LA.vector_norm(output - target, ord=1, dim=dims) | ||
|
|
||
| intersection = (output_sum + target_sum - difference) / 2 # TP | ||
| fp = output_sum - intersection | ||
| fn = target_sum - intersection | ||
|
|
||
| tversky_score = (intersection + smooth) / ( | ||
| intersection + alpha * fp + beta * fn + smooth | ||
| ).clamp_min(eps) |
There was a problem hiding this comment.
As far as I understand we can just call soft_tversky_score here?
Comment on lines
+98
to
+102
| [ | ||
| [[1, 1, 1, 1], [1, 1, 1, 1], 0.0, 1e-5, 0.5, 0.5, 1.0], | ||
| [[0, 1, 1, 0], [0, 1, 1, 0], 0.0, 1e-5, 0.5, 0.5, 1.0], | ||
| [[1, 1, 1, 1], [0, 0, 0, 0], 1.0, 1e-5, 0.5, 0.5, 1.0], | ||
| [[1, 0, 1, 0], [0, 1, 0, 0], 1.0, 1e-5, 0.5, 0.5, 1.0], |
There was a problem hiding this comment.
Can you please add a test case with gamma != 1?
|
The focal Tversky loss has already been implemented. |
|
Indeed 😄 missed it, probably a documentation issue! Thanks for pointing it @zifuwanggg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Added:
Changed:
Maybe you can take a look at it.