Add websocket support #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have we tried to get any of this upstreamed into goproxy? What's the progress on that? |
|
This is the reverse proxy PR: elazarl/goproxy#143 |
| } | ||
|
|
||
| func (proxy *ProxyHttpServer) proxyWebsocket(ctx *ProxyCtx, dest io.ReadWriter, source io.ReadWriter) { | ||
| errChan := make(chan error, 2) |
There was a problem hiding this comment.
Why two? If one fails, do we really need to wait for the other to fail before exiting this function?
There was a problem hiding this comment.
It's buffered to 2 just in case both goroutines error out before the <- (protecting from a panic). If there's a reason to believe that can't happen I can change this
|
LGTM!!!11 |
|
How did this works? AFAIK ws connection request doesn't supports any extra headers like "Authorization". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates goproxy to the fork supports websockets