Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cicd: update go version #2016

Merged
merged 3 commits into from
Apr 9, 2024
Merged

cicd: update go version #2016

merged 3 commits into from
Apr 9, 2024

Conversation

hdonnay
Copy link
Member

@hdonnay hdonnay commented Mar 22, 2024

This rebuilds some of the testing workflow based on the claircore workflows (consolidating these is an ongoing process 🫠) and then updates the go version for modules in this repo.

Along the way, I added another lint to check version skew on the Dockerfile and docker-compose.yaml.

@hdonnay hdonnay force-pushed the chore/go-version branch 30 times, most recently from 422df5c to 6682c35 Compare March 22, 2024 21:46
@hdonnay hdonnay force-pushed the chore/go-version branch 4 times, most recently from e877d5f to 05340f7 Compare March 25, 2024 20:26
@hdonnay hdonnay force-pushed the chore/go-version branch 2 times, most recently from 315ed38 to 5889dbd Compare April 8, 2024 16:37
@hdonnay hdonnay marked this pull request as ready for review April 8, 2024 18:15
@hdonnay hdonnay requested a review from a team as a code owner April 8, 2024 18:15
@hdonnay hdonnay requested review from crozzy and removed request for a team April 8, 2024 18:15
@hdonnay
Copy link
Member Author

hdonnay commented Apr 8, 2024

Also switch the versions (and thus names) to stable and oldstable, which will automatically track the go upstream's supported versions.

Copy link
Collaborator

@crozzy crozzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM not sure why the tests are stalled

@hdonnay hdonnay merged commit 6a3ce17 into main Apr 9, 2024
14 checks passed
@hdonnay hdonnay deleted the chore/go-version branch April 9, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants