Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix 45 addons config #46

Merged
merged 7 commits into from
Jan 17, 2025
Merged

Bugfix 45 addons config #46

merged 7 commits into from
Jan 17, 2025

Conversation

jwloka
Copy link
Member

@jwloka jwloka commented Jan 17, 2025

This PR changes the handling of addons and targets in the compiler. The main changes include:

  • Method calls for retrieving addons need to include a target parameter (e.g., getAvailableAddons())
  • Refining the logic for handling targets, compilationConfig and loaderOptions in webpack override properties from config files.
  • Adding documentation comments to explain the use of configuration options

Improvements to addon handling:

Updated the getAvailableAddons method to include a target parameter in test cases.
Modified the getAvailableAddons method to handle the * target more effectively.
Updated multiple test cases to include the * target parameter when calling getAvailableAddons.

Enhancements to target handling:

Removed the default assignment of ["*"] to targets in the setOptions method.
Added documentation comments for the targets and transpileOnly properties.
Added documentation comments for various properties, including addons, addonsDir, and targets.

Code simplification and consistency:

Simplified the assignment of projectDirectory using optional chaining.
Added default targets to CompilationEnv and updated the getActiveAddons method to accept a target parameter.

These changes improve the flexibility and clarity of the compiler's handling of addons and targets, ensuring that the correct addons are used based on the specified targets.

@jwloka jwloka added the bug Something isn't working label Jan 17, 2025
@jwloka jwloka requested a review from meck93 January 17, 2025 14:53
@jwloka jwloka self-assigned this Jan 17, 2025
@meck93 meck93 merged commit fb916a2 into develop Jan 17, 2025
2 checks passed
@meck93 meck93 deleted the bugfix-45--addons-config branch January 17, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants