Skip to content

Commit

Permalink
c Downgrades FIXMEs that don't need fixing yet to TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
jwloka committed Apr 15, 2024
1 parent 881844d commit 4b21959
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions packages/compiler/src/command.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ describe("addCompileCommand", () => {
expect(target.getOptions().debug).toBe(true);
});

// FIXME: This test is failing because the compiler watch support is broken.
// TODO: This test is failing because the compiler watch support is broken.
it.skip("should set watch compiler option w/ --watch cli argument", () => {
const target = new Compiler(createOptions({}, new NoReporter()));

Expand All @@ -220,7 +220,7 @@ describe("addCompileCommand", () => {
expect(target.getOptions().transpileOnly).toBe(true);
});

// FIXME: This test requires a decision regarding our explicit logic for additional cmdline arguments - do provide them through the CompilerOptions or do we reject them.
// TODO: This test requires a decision regarding our explicit logic for additional cmdline arguments - do provide them through the CompilerOptions or do we reject them.
it.skip("should inform CLI user about tsconfig usage for unsupported command line arguments", () => {
console.error = line => {
throw new Error(line.toString());
Expand Down
4 changes: 2 additions & 2 deletions packages/compiler/src/options.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {
resolveCompilationConfig,
resolveProjectConfig as resolveTsConfig,
resolveTargets,
updateCompilerOptions
updateCompilerOptions,
} from "@quatico/websmith-core";
import { dirname, join } from "path";
import ts from "typescript";
Expand Down Expand Up @@ -66,7 +66,7 @@ export const createOptions = (args: CompilerArguments, reporter: Reporter = new
buildDir: args.buildDir ?? system.getCurrentDirectory(),
config: compilationConfig,
debug: args.debug ?? DEFAULTS.debug,
// FIXME: Do we need lib files, or is injecting them into the system sufficient?
// TODO: Do we need lib files, or is injecting them into the system sufficient?
// files?: Record<string, string>;
tsconfig,
project: tsconfig.options,
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/compiler/Compiler.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -671,7 +671,7 @@ describe("report", () => {
});
});

// FIXME: Update with BrowserSystem testSystem when BrowserSystem supports watch
// TODO: Update with BrowserSystem testSystem when BrowserSystem supports watch
describe("watch", () => {
let testObj: Compiler;

Expand Down

0 comments on commit 4b21959

Please sign in to comment.