Print slotted content within the assigned slot #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace prettier2 with prettier3
Upgrade to node.js version 20
…tted content into the assined slot
meck93
requested changes
Apr 4, 2024
| "typescript": "^5.4.3" | ||
| }, | ||
| "engines": { | ||
| "node": ">=20", |
There was a problem hiding this comment.
@jwloka wir supporten nicht nur >= Node 20, oder?
Weil so, generieren wir den Verwendern immer eine Warning: https://docs.npmjs.com/cli/v10/configuring-npm/package-json#engines
Unless the user has set the [engine-strict config](https://docs.npmjs.com/cli/v10/using-npm/config#engine-strict) flag, this field is advisory only and will only produce warnings when your package is installed as a dependency.
src/renderToString.spec.ts
Outdated
| slottedContent: "map-contents", | ||
| } as any); | ||
|
|
||
| expect(actual).toMatchInlineSnapshot(`""`); |
There was a problem hiding this comment.
Da ist wohl etwas zwischen den Commits kaputt gegangen.
Suggested change
| expect(actual).toMatchInlineSnapshot(`""`); | |
| expect(actual).toMatchInlineSnapshot(`" | |
| <p> | |
| EXPECTED | |
| </p> | |
| "`); |
meck93
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some test snapshots make it hard to understand what content is slotted into a particular slot. This PR provides a new rendering option 'slottedContent'. Use value "reveal-contents" to show slotted content in its original and its assigned (slotted) position. Use value "map-contents" to move the slotted nodes into the assigned slot.