better string literals normalization

Signed-off-by: Iskander Sharipov <[email protected]>
quasilyte · Jan 31, 2019 · 544300f · 544300f
1 parent b1a996f
commit 544300f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/testdata/normalize_expr.go b/testdata/normalize_expr.go
@@ -14,6 +14,14 @@ func identityTest() {
 	_, _ = 12412.312, 12412.312
 }
 
+func stringLiteralsTest() {
+	_, _ = ``, ""
+	_, _ = `\\`, "\\\\"
+	_, _ = `\d+`, "\\d+"
+	_, _ = `123`, "123"
+	_, _ = "\n"+``+"\n", "\n\n"
+}
+
 func defaultSlicingBoundsTest() {
 	var xs []int
 	var s string

diff --git a/utils.go b/utils.go
@@ -58,7 +58,7 @@ func constValueNode(cv constant.Value) ast.Expr {
 		v := constant.StringVal(cv)
 		return &ast.BasicLit{
 			Kind:  token.STRING,
-			Value: `"` + v + `"`,
+			Value: strconv.Quote(v),
 		}
 
 	case constant.Int: