Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add noEscDismiss props to QMenu #17784

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Conversation

maxfromit
Copy link

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • [There should be a simple way to prevent the menu from being dismissed when the Esc key is pressed. For example, when using shadow text in an input field, the Esc key can be used to cancel the shadow text. However, if a menu is also displayed while the input is focused, pressing the Esc key dismisses the menu, which can be distracting. This is my new feature discussion: https://github.com/Add noEscDismiss props to QMenu #17783] A convincing reason for adding this feature (to avoid wasting your time, it's best to [start a new feature discussion]

Other information:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant