Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unmatched paren (matches error log more closely) #1112

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove unmatched paren (matches error log more closely) #1112

wants to merge 1 commit into from

Conversation

piercetrey-figure
Copy link

@piercetrey-figure piercetrey-figure commented Mar 27, 2024 •
edited
Loading

In submitting this contribution, I agree to the current Software AG contributor agreement as referred to here:
https://github.com/quartz-scheduler/contributing/blob/main/CONTRIBUTING.md

This PR...

Changes

  • Removes an unmatched paren that was annoying my coworker @hyperschwartz
  • Opted to remove the paren rather than add a matching one so it matches the log mesage above on lines 211-212

Checklist

  • tested locally
  • updated the docs
  • added appropriate test
  • signed-off on the above mentioned SoftwareAG contributor agreement via git commit -s on my commits.
    (If you're not using command-line, you can use a browser extension )

Fixes #

@piercetrey-figure piercetrey-figure marked this pull request as ready for review March 27, 2024 16:10
@celloman
Copy link

Ohhh we are building momentum! Anyone with the powers want to chime in? 😆

@bcode2
Copy link

bcode2 commented Aug 30, 2024

Long live Quartz!!! :)

@celloman
Copy link

Oh dang, this is a party now!

@celloman
Copy link

Just for reference, I switched GItHub accounts since I originally created this issue 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-beckmann t-beckmann t-beckmann approved these changes

@eartymiuk444 eartymiuk444 eartymiuk444 approved these changes

@hyperschwartz hyperschwartz hyperschwartz approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@piercetrey-figure @celloman @bcode2 @t-beckmann @eartymiuk444 @hyperschwartz