Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When storing job with replace check update count returned #1086

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

t-beckmann
Copy link

This is to detect non-durable job suddenly disappearing when concurrently completing. On MariaDB/MySQL the fall-through code path select-update-insert can be taken due to consistent nonblocking read and multi-version concurrency control.

In submitting this contribution, I agree to the current Software AG contributor agreement as referred to here:
https://github.com/quartz-scheduler/contributing/blob/main/CONTRIBUTING.md

Changes

The code change checks the update count returned when storing a job.

Checklist

  • tested locally
  • updated the docs (not applicable, bug fix only)
  • added appropriate test (not applicable, storeJob method covered in tests already)
  • signed-off on the above mentioned SoftwareAG contributor agreement via git commit -s on my commits.

Fixes #1085

--
This is to detect non-durable job suddenly disappearing when concurrently completing. On MariaDB/MySQL the fall-through code path select-update-insert can be taken due to consistent nonblocking read and multi-version concurrency control.

Signed-off-by: Thomas Beckmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Foreign key constraint violation when storing trigger to non-durable job on MariaDB/MySQL
1 participant