-
Notifications
You must be signed in to change notification settings - Fork 26
Make quarto_render(as_job = TRUE)
wrapable
#105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
cd18da9
Make `quarto_render()` wrapable
salim-b 332dd4a
Cosmetic fixes
salim-b 50bf4f2
Avoid rlang
salim-b 878873e
Fix test
salim-b 037a92a
Fix order in test
salim-b f4568c3
Tweak test
salim-b 0665e5a
Cosmetic fix
salim-b c7b1678
Merge branch 'main' into improve-render
salim-b 2068658
Merge commit '2fd494eb69f0dd6495bf6f8303075f451f8e8186'
cderv 1438bd0
Use temp file infrastructure for tests
cderv d69af0c
Merge branch 'main' into improve-render
salim-b 7885339
Tweak test
salim-b 193bc46
Merge branch 'improve-render' of github.com:salim-b/quarto-r into imp…
salim-b 497d895
Merge branch 'main' into improve-render
salim-b bc704d1
Merge branch 'main' into improve-render
cderv 8056d93
correctly skip test
cderv c9a0fd6
Add note to test
cderv 0928f53
Merge branch 'main' into improve-render
cderv 3c17e0e
add test for message checking we are in job part
cderv d93854b
bump version
cderv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
Package: quarto | ||
Title: R Interface to 'Quarto' Markdown Publishing System | ||
Version: 1.4.4.9011 | ||
Version: 1.4.4.9012 | ||
Authors@R: c( | ||
person("JJ", "Allaire", , "[email protected]", role = "aut", | ||
comment = c(ORCID = "0000-0003-0174-9868")), | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to handle this a bit differently for complex wrapping calls that would use
...
for example. In this case, it will not work. rlang maybe be useful for this. 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right, I didn't test with a wrapper function that uses dots, I only tested simple named args. Feel free to refactor and expand on this PR as you see fit!