Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ff-matrix: Callout features #9841

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

ff-matrix: Callout features #9841

wants to merge 5 commits into from

Conversation

cscheid
Copy link
Collaborator

@cscheid cscheid commented Jun 1, 2024

Progress towards #9832.

  • html

Fixes

This fixes the inconsistent border radii for callout headers in HTML, from

image

to

image

@gordonwoodhull
Copy link
Contributor

I would do most of these as cases within a feature directory, instead of calling each case its own feature. They are mostly of interest to developers so they could be shown under the detailed view.

(But all questions of feature granularity are subjective.)

@cscheid
Copy link
Collaborator Author

cscheid commented Jun 1, 2024

I would do most of these as cases within a feature directory, instead of calling each case its own feature.

The question, I guess, hinges on whether the single document still allows tests and minimal examples without a clunky .qmd full of extraneous divs (for the selectors)

@gordonwoodhull
Copy link
Contributor

Still separate qmd files, just in a directory. Like all these cases for CSS border, which we wouldn't want to expose to the end user in the ff matrix, but which are helpful to the developer:

https://github.com/quarto-dev/quarto-cli/tree/main/dev-docs/feature-format-matrix/qmd-files/css-properties/border

(Here I think I went too far, and some of the invalid/error cases belong in regular smoke tests.)

@cscheid cscheid added this to the v1.6 milestone Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants