Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Research/windows uniciode paths #8831

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Research/windows uniciode paths #8831

wants to merge 3 commits into from
+40 −28

Conversation

dragonstyle
Copy link
Collaborator

@dragonstyle dragonstyle commented Feb 22, 2024 •
edited
Loading

  • LUA module loading
  • To make LUA module loading work, we load the module for license.lua different, but this clearly has issues still
  • Installing TinyTex
  • Known issue with python path handling - we are failing to initialize the logger in log.py#19 likely due to incorrect path encoding
  • Known issue can occur when attempting to read temp file path (this has been transient so I haven't pinned down when it happens yet)

@dragonstyle
Fix module loading with unicode paths on windows
adad764 
#8530
@dragonstyle
Core - Windows Zip
55ddff0 
Avoid paths that may have unicode characters in them being passed to ExtractToDirectory.
@dragonstyle
LUA Dendependencies - Hide File Path
52d39c1 
encode the file path to hide it from the environment variables
@cscheid cscheid self-assigned this Feb 22, 2024
@dragonstyle dragonstyle mentioned this pull request Feb 22, 2024
Open
@cderv cderv mentioned this pull request May 24, 2024
Closed
@cscheid cscheid added this to the Future milestone Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cscheid cscheid

Labels
None yet
Projects
None yet
Milestone
Future
Development

Successfully merging this pull request may close these issues.
2 participants
@dragonstyle @cscheid