-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add appimage build #11570
base: main
Are you sure you want to change the base?
feat: add appimage build #11570
Conversation
Thanks for the PR. I'm a bit wary of adding additional maintenance burden in our installers, which is already non-trivial for us. I'm in principle supportive, but I would like to test drive this a bit. Is there a way you can run this off of your own repo so we can verify that there are no hiccups as we upgrade dependencies, etc, and then we merge it here? |
fdd8783
to
3d7590d
Compare
Thanks for your feedback! I can understand that you hesitate to add another installer. I created in my repo a new branch that always builds the installers. You can access the artifacts here: https://github.com/mutlusun/quarto-cli/actions/runs/12142841341 If you want to, I can update the branch to your latest main branch. This way, you can see if something breaks or not. |
Let me propose to you the following. You run and maintain the |
Thanks for your feedback! I'm sorry for my late reply. I can provide appimage builds in a separate repository. However, then I will not try to stay on the Would you be open to a contribution of this code to quarto-release-bundles? I think, appimage is also a release bundle / some kind of package management and it's probably easier for users to find it there instead of a private repository under my name. Thanks for your consideration! |
@cscheid I like this idea of having this new bundling in the other repo. |
I like this idea as well. |
@mutlusun please submit a PR in quarto-dev/quarto-release-bundles and I'll review it. THank you ! |
Welcome to the quarto GitHub repo!
We are always happy to hear feedback from our users.
To file a pull request, please follow these instructions carefully: https://yihui.org/issue/#bug-reports
If you're a collaborator from outside
quarto-dev
making changes larger than a typo, please make sure you have filed an individual or corporate contributor agreement. You can send the signed copy to [email protected].Also, please complete and keep the checklist below.
Description
This PR adds an appimage build to the release tarballs. Appimage is a packaging format that runs on linux and is able to provide all necessary files within one file/package. Users only need to download the file, make it executable, and can run the software. This eliminates the manual moving of the tarball to
/opt/
what requires root privileges and symlinking, etc. (see the tarball installation guide).Related issues: #4505
Checklist
I have (if applicable):
I'm happy to file the contributor agreement, update the changelog, and open a documentation PR if you agree with the changes.