Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Quarkus GitHub Lottery to quarkusio/quarkusio.github.io #1959

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

yrodiere
Copy link
Member

@yrodiere yrodiere commented Apr 22, 2024

Also needed, beyond the content of this PR:

  • An admin needs to add the Lottery app to this repository
  • We need to set up labels (see TODOs and comments) if we want to handle triage/maintenance notifications.
  • We need to ping other people who would want to get notified, so that they register themselves in the config file.

Comment on lines +25 to +23
stewardship:
delay: P21D
timeout: P3D
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I picked a shorter delay/timeout than on quarkusio/quarkus, because we have no maintainers on this repo. Was 60d/14d on quarkusio/quarkus.

See:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

.github/quarkus-github-lottery.yml Outdated Show resolved Hide resolved
Comment on lines 5 to 6
triage:
# TODO: No such label on quarkusio... ? This won't work without a label.
label: "triage/needs-triage"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. We also need this label to be applied automatically to new issues... On quarkusio/quarkus I think that's the bot's responsibility.

Here I suppose we could add the label as part of issue templates? Or does it make sense to enable the bot here @gsmet ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dunno. Personally I'm not sure I will have the time to triage things here and we don't have that many areas.

Looks a bit too much to my taste.

But I'm not the one who asked for this so feel free to ignore me :).

Comment on lines 29 to 38
- username: "gsmet"
timezone: "Europe/Paris"
stewardship:
days: ["MONDAY"]
maxIssues: 3
- username: "maxandersen"
timezone: "Europe/Paris"
stewardship:
days: ["WEDNESDAY", "FRIDAY"]
maxIssues: 3
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now I only enabled stewardship, since it's the only feature that makes sense in the absence of labels.

Please check the days/maxIssues match what you would like, though.

See:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@holly-cummins you wanna volunteer as extra lottery winner ? :)

@yrodiere yrodiere requested review from maxandersen and gsmet April 22, 2024 13:50
Copy link

github-actions bot commented Apr 22, 2024

🙈 The PR is closed and the preview is expired.

@maxandersen
Copy link
Member

i added some labels and started reviewing random old ones which made me add a few more labels.

its obvious we could benefit from some more collective lottery review :)

@yrodiere yrodiere changed the title Add Quarkus GitHub Lottery Add Quarkus GitHub Lottery to quarkusio/quarkusio.github.io Apr 23, 2024
@yrodiere
Copy link
Member Author

@maxandersen I updated the PR to automatically add the label triage/needs-triage to newly created bug reports, to assign you to triage, and my to maintenance of area/search (though if @marko-bekhta wants to take over I'll gladly let him :D)

You may want to add more volunteers for triaging and maintenance, and maybe add the Quarkus GitHub Bot so that maintainers get notified when you assign an issue to an area.

Apart from that, ready to merge IMO.

@marko-bekhta
Copy link
Contributor

maintenance of area/search (though if @marko-bekhta wants to take over I'll gladly let him :D)

is that about search.quarkus.io and its usage within quarkus.io ? If so, I can do that and let you have some of your time back 😃

@yrodiere
Copy link
Member Author

maintenance of area/search (though if @marko-bekhta wants to take over I'll gladly let him :D)

is that about search.quarkus.io and its usage within quarkus.io ? If so, I can do that and let you have some of your time back 😃

Thanks, done. Feel free to adjust the days or number of issues.

@yrodiere
Copy link
Member Author

Okay, if nobody is going to do it, I will: merging.

@maxandersen you need to address this follow-up:

You may want to add more volunteers for triaging and maintenance, and maybe add the Quarkus GitHub Bot so that maintainers get notified when you assign an issue to an area.

@yrodiere yrodiere merged commit 1670a38 into quarkusio:develop Apr 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants