-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Quarkus GitHub Lottery to quarkusio/quarkusio.github.io #1959
Conversation
stewardship: | ||
delay: P21D | ||
timeout: P3D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I picked a shorter delay/timeout than on quarkusio/quarkus, because we have no maintainers on this repo. Was 60d/14d on quarkusio/quarkus.
See:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense
.github/quarkus-github-lottery.yml
Outdated
triage: | ||
# TODO: No such label on quarkusio... ? This won't work without a label. | ||
label: "triage/needs-triage" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
created!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. We also need this label to be applied automatically to new issues... On quarkusio/quarkus I think that's the bot's responsibility.
Here I suppose we could add the label as part of issue templates? Or does it make sense to enable the bot here @gsmet ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dunno. Personally I'm not sure I will have the time to triage things here and we don't have that many areas.
Looks a bit too much to my taste.
But I'm not the one who asked for this so feel free to ignore me :).
.github/quarkus-github-lottery.yml
Outdated
- username: "gsmet" | ||
timezone: "Europe/Paris" | ||
stewardship: | ||
days: ["MONDAY"] | ||
maxIssues: 3 | ||
- username: "maxandersen" | ||
timezone: "Europe/Paris" | ||
stewardship: | ||
days: ["WEDNESDAY", "FRIDAY"] | ||
maxIssues: 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now I only enabled stewardship, since it's the only feature that makes sense in the absence of labels.
Please check the days/maxIssues match what you would like, though.
See:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@holly-cummins you wanna volunteer as extra lottery winner ? :)
🙈 The PR is closed and the preview is expired. |
i added some labels and started reviewing random old ones which made me add a few more labels. its obvious we could benefit from some more collective lottery review :) |
@maxandersen I updated the PR to automatically add the label You may want to add more volunteers for triaging and maintenance, and maybe add the Quarkus GitHub Bot so that maintainers get notified when you assign an issue to an area. Apart from that, ready to merge IMO. |
is that about |
Thanks, done. Feel free to adjust the days or number of issues. |
Okay, if nobody is going to do it, I will: merging. @maxandersen you need to address this follow-up:
|
Also needed, beyond the content of this PR: