Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump org.mvnpm.at.vaadin:router from 1.7.5 to 2.0.0 #46288

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 14, 2025

Bumps org.mvnpm.at.vaadin:router from 1.7.5 to 2.0.0.

Release notes

Sourced from org.mvnpm.at.vaadin:router's releases.

v2.0.0

API documentation

With the v2 major release, Vaadin Router was entirely ported to TypeScript. We removed outdated code and features targeting MSIE 11, bower, and HTML imports, and updated the libraries and build tools we use. In addition, we introduced generic parameters on the router core types, which facilitates extendibility of the route definition on the user end.

New Features

  • Generic route type support. The Router class supports route object extensions provided with a generic argument. This allows adding custom metadata directly on the route object with keeping consistent types:
    /**
     * Custom route metadata.
     */
    type RouteMeta = Readonly<{
      title: string;
    }>;
    const router = new Router<RouteMeta>(document.body);
    router.setRoutes([
    {
    path: '',
    component: 'page-index',
    title: 'Index page',
    },
    ]);

Breaking Changes

  • Removing support for MS Internet Explorer.
  • Support for bundle route key was removed. Now that using ES modules is common, for lazy loading of views use dynamic import from the action callback.
  • The Router namespace export was removed. For referencing router types, either refer to exports directly, or use ES module namespace import:
    import type * as RouterTypes from '@vaadin/router';
  • The path-to-regexp library was updated to v6.3.0. This update brought some behavior altering changes affecting route parameter parsing and matching. See to the library README for the supported patterns.
  • Some TypeScript interfaces of the router library were changed with introducing generic support:
    • The Context type was replaced with the RouteContext generic type.
    • The ComponentResult type is replaced with the standard HTMLElement type.
    • The AfterEnterObserver, AfterLeaveObserver, BeforeEnterObserver, BeforeLeaveObserver interfaces were combined into the single generic WebComponentInterface with multiple optional user callbacks.
    • The ActionFn function type has no direct alternative yet. Use the key of the Route type: NonNullable<Route["action"]>.

Known Limitations

The following known issues of the router v2.0.0 release will be addressed in the next v2.0.1 release:

  • Type compatibility with the Router v1 is lacking due to missing type definitions for Router v1 types: Context, ComponentResult, AfterEnterObserver, AfterLeaveObserver, BeforeEnterObserver, BeforeLeaveObserver observer interfaces.
  • The Router requires ES2022 target setting in TypeScript due to relying on the ErrorOptions type, see vaadin/router#897

In addition, the live router demos are not available yet. We're currently working on porting them from HTML imports and Polymer toolset to ES modules, TypeScript and Vite.

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [org.mvnpm.at.vaadin:router](https://github.com/vaadin/vaadin-router) from 1.7.5 to 2.0.0.
- [Release notes](https://github.com/vaadin/vaadin-router/releases)
- [Commits](vaadin/router@v1.7.5...v2.0.0)

---
updated-dependencies:
- dependency-name: org.mvnpm.at.vaadin:router
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the area/dependencies Pull requests that update a dependency file label Feb 14, 2025
Copy link

quarkus-bot bot commented Feb 14, 2025

/cc @phillip-kruger (mvnpm)

Copy link

quarkus-bot bot commented Feb 15, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit dc6e779.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Tests - JDK 17 Logs Raw logs 🔍
JVM Tests - JDK 21 Build Failures Logs Raw logs 🔍
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs 🔍
Devtools Tests - JDK 17 Build Failures Logs Raw logs 🔍
Devtools Tests - JDK 21 Build Failures Logs Raw logs 🔍
Devtools Tests - JDK 17 Windows Build Failures Logs Raw logs 🔍

Full information is available in the Build summary check run.
You can consult the Develocity build scans.

Failures

⚙️ JVM Tests - JDK 21 #

- Failing: devtools/cli 

📦 devtools/cli

io.quarkus.cli.CliProjectGradleTest. - History - More details - Source on GitHub

java.lang.StackOverflowError
	at java.base/java.lang.ThreadLocal.get(ThreadLocal.java:185)
	at java.base/java.lang.ThreadLocal.get(ThreadLocal.java:172)
	at com.gradle.maven.scan.extension.test.listener.obfuscated.l.b.a(SourceFile:24)
	at com.gradle.maven.scan.extension.test.listener.obfuscated.l.b.print(SourceFile:131)
	at com.gradle.maven.scan.extension.test.listener.obfuscated.h.a.a(SourceFile:102)
	at com.gradle.maven.scan.extension.test.listener.obfuscated.h.a.b(SourceFile:65)
	at com.gradle.maven.scan.extension.test.listener.obfuscated.l.a.a(SourceFile:85)

io.quarkus.cli.CliProjectGradleTest.testCreateAppDefaults - History - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
Expected OK return code. Result:
result: {
  exitCode: {1},
  system_err: {
FAILURE: Build failed with an exception.

* What went wrong:

io.quarkus.cli.CliProjectGradleTest.testCreateAppDefaultsWithKotlinDSL - History - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
Expected OK return code. Result:
result: {
  exitCode: {1},
  system_err: {
FAILURE: Build failed with an exception.

* What went wrong:

io.quarkus.cli.CliProjectGradleTest.testCreateAppOverrides - History - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
Expected OK return code. Result:
result: {
  exitCode: {1},
  system_err: {
FAILURE: Build failed with an exception.

* What went wrong:

⚙️ JVM Tests - JDK 17 Windows #

- Failing: devtools/cli 

📦 devtools/cli

io.quarkus.cli.CliProjectGradleTest. - History - More details - Source on GitHub

java.lang.StackOverflowError
	at java.base/java.io.BufferedWriter.write(BufferedWriter.java:233)
	at java.base/java.io.Writer.write(Writer.java:249)
	at java.base/java.io.PrintStream.write(PrintStream.java:697)
	at java.base/java.io.PrintStream.print(PrintStream.java:863)
	at com.gradle.maven.scan.extension.test.listener.obfuscated.l.b.print(SourceFile:131)
	at com.gradle.maven.scan.extension.test.listener.obfuscated.h.a.a(SourceFile:102)
	at com.gradle.maven.scan.extension.test.listener.obfuscated.h.a.b(SourceFile:65)

io.quarkus.cli.CliProjectGradleTest.testCreateAppDefaults - History - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
Expected OK return code. Result:
result: {
  exitCode: {1},
  system_err: {
FAILURE: Build failed with an exception.

* What went wrong:

io.quarkus.cli.CliProjectGradleTest.testCreateAppDefaultsWithKotlinDSL - History - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
Expected OK return code. Result:
result: {
  exitCode: {1},
  system_err: {
FAILURE: Build failed with an exception.

* What went wrong:

io.quarkus.cli.CliProjectGradleTest.testCreateAppOverrides - History - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
Expected OK return code. Result:
result: {
  exitCode: {1},
  system_err: {
FAILURE: Build failed with an exception.

* What went wrong:

⚙️ Devtools Tests - JDK 17 #

- Failing: integration-tests/devtools 

📦 integration-tests/devtools

io.quarkus.devtools.codestarts.quarkus.KotlinSerializationCodestartTest.buildAllProjectsGradle line 61 - History - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
[Run project return status should be zero] 
expected: 0
 but was: 1
	at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildProject(QuarkusCodestartTest.java:158)
	at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildAllProjects(QuarkusCodestartTest.java:145)
	at io.quarkus.devtools.codestarts.quarkus.KotlinSerializationCodestartTest.buildAllProjectsGradle(KotlinSerializationCodestartTest.java:61)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

⚙️ Devtools Tests - JDK 21 #

- Failing: integration-tests/devtools 

📦 integration-tests/devtools

io.quarkus.devtools.codestarts.quarkus.KotlinSerializationCodestartTest.buildAllProjectsGradle line 61 - History - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
[Run project return status should be zero] 
expected: 0
 but was: 1
	at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildProject(QuarkusCodestartTest.java:158)
	at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildAllProjects(QuarkusCodestartTest.java:145)
	at io.quarkus.devtools.codestarts.quarkus.KotlinSerializationCodestartTest.buildAllProjectsGradle(KotlinSerializationCodestartTest.java:61)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

⚙️ Devtools Tests - JDK 17 Windows #

- Failing: integration-tests/devtools 

📦 integration-tests/devtools

io.quarkus.devtools.codestarts.quarkus.KotlinSerializationCodestartTest.buildAllProjectsGradle line 61 - History - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
[Run project return status should be zero] 
expected: 0
 but was: 1
	at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildProject(QuarkusCodestartTest.java:158)
	at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildAllProjects(QuarkusCodestartTest.java:145)
	at io.quarkus.devtools.codestarts.quarkus.KotlinSerializationCodestartTest.buildAllProjectsGradle(KotlinSerializationCodestartTest.java:61)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingWorkingAppPropsTestCase.testContinuousTestingScenario3 - History

  • io.quarkus.builder.BuildException: Build failure: Build failed due to errors [error]: Build step io.quarkus.apicurio.registry.devservice.DevServicesApicurioRegistryProcessor\#startApicurioRegistryDevService threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image quay.io/apicurio/apicurio-registry-mem:2.4.2.Final at io.quarkus.apicurio.registry.devservice.DevServicesApicurioRegistryProcessor.startApicurioRegistryDevService(DevServicesApicurioRegistryProcessor.java:90) at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732) at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856) - java.lang.RuntimeException
java.lang.RuntimeException: 
io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.apicurio.registry.devservice.DevServicesApicurioRegistryProcessor#startApicurioRegistryDevService threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image quay.io/apicurio/apicurio-registry-mem:2.4.2.Final
	at io.quarkus.apicurio.registry.devservice.DevServicesApicurioRegistryProcessor.startApicurioRegistryDevService(DevServicesApicurioRegistryProcessor.java:90)
	at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732)
	at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)
	at io.quarkus.builder.BuildContext.run(BuildContext.java:255)
	at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)

Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 15, 2025

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Feb 15, 2025
@dependabot dependabot bot deleted the dependabot/maven/org.mvnpm.at.vaadin-router-2.0.0 branch February 15, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/dev-ui triage/flaky-test triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant