Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor JWT quickstart doc updates #45530

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

sberyozkin
Copy link
Member

No description provided.

Copy link

github-actions bot commented Jan 13, 2025

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I've offered some minor suggestions.

@sberyozkin sberyozkin force-pushed the jwt_quickstart_doc_updates branch from 324f450 to 9f3ae12 Compare January 14, 2025 10:26
@sberyozkin
Copy link
Member Author

@rolfedh Hi Rolfe, I've applied your suggestions with tiny modifications, please double check

This comment has been minimized.

docs/src/main/asciidoc/security-jwt.adoc Outdated Show resolved Hide resolved
@sberyozkin sberyozkin force-pushed the jwt_quickstart_doc_updates branch from 55c2c89 to 7f50d40 Compare January 14, 2025 16:53
@sberyozkin
Copy link
Member Author

@rolfedh Sure, applied your suggestion. Let me know if it looks fine now.

@gastaldi Can you please approve once Rolfe confirms he is OK with these updates ?

Copy link

quarkus-bot bot commented Jan 14, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 7f50d40.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@sberyozkin
Copy link
Member Author

OK, let me merge, thanks @rolfedh @gastaldi

@sberyozkin sberyozkin merged commit c085eeb into quarkusio:main Jan 14, 2025
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Jan 14, 2025
@sberyozkin sberyozkin deleted the jwt_quickstart_doc_updates branch January 14, 2025 17:53
To do this, run the following command:
Ensure the <<run-application, application is running>> before generating the JSON Web Token (JWT) for the `TokenSecuredResource` endpoint.

Next, use the following command to generate the JWT:

.Command to generate JWT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sberyozkin,

It looks like you’re considering moving the command to a separate code block under this heading or possibly combining these two headings. Is that the direction you’re thinking? Let me know if there’s anything I can do to assist!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants