Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTel metrics for Microprofile Telemetry 2.0 #43678

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brunobat
Copy link
Contributor

@brunobat brunobat commented Oct 3, 2024

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 3, 2024

/cc @radcortez (opentelemetry)

@brunobat brunobat changed the title OTel metrics for Microprofile 2.0 OTel metrics for Microprofile Telemetry 2.0 Oct 3, 2024
@brunobat brunobat marked this pull request as draft October 3, 2024 11:07
@brunobat
Copy link
Contributor Author

brunobat commented Oct 3, 2024

Will include the TCK updates as well... Set to draft until then.

Copy link

github-actions bot commented Oct 3, 2024

🎊 PR Preview 7f5dc76 has been successfully built and deployed to https://quarkus-pr-main-43678-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@Ladicek
Copy link
Contributor

Ladicek commented Oct 3, 2024

Off topic (but not all that much I guess): are you planning to support MetricsCapabilityBuildItem? (And the related SPIs too, probably?)

@brunobat
Copy link
Contributor Author

brunobat commented Oct 3, 2024

Off topic (but not all that much I guess): are you planning to support MetricsCapabilityBuildItem? (And the related SPIs too, probably?)

I'll decide that after evaluating the future Micrometer to OpenTelemetry bridge.
It it goes well, there might be no more automatic metrics for OTel.

@brunobat
Copy link
Contributor Author

brunobat commented Oct 8, 2024

#43752 is needed for the native image tests to pass because it includes an OTel side instrumentation fix.

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 8, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit cd37073.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 8, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit cd37073.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
Native Tests - Misc4 Build Failures Logs Raw logs 🔍

Full information is available in the Build summary check run.
You can consult the Develocity build scans.

Failures

⚙️ Native Tests - Misc4 #

- Failing: integration-tests/opentelemetry 

📦 integration-tests/opentelemetry

io.quarkus.it.opentelemetry.MetricsIT.testJvmMetrics - History - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.MetricsTest was not fulfilled within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.it.opentelemetry.MetricsTest.testJvmMetrics(MetricsTest.java:77)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants