Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump com.fasterxml.jackson:jackson-bom from 2.17.2 to 2.18.0 #43637

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 1, 2024

Bumps com.fasterxml.jackson:jackson-bom from 2.17.2 to 2.18.0.

Commits
  • 7236550 [maven-release-plugin] prepare release jackson-bom-2.18.0
  • 58c2791 Prepare for 2.18.0 release
  • 3775318 Merge pull request #73 from FasterXML/dependabot/github_actions/github-action...
  • 540b7e7 Bump actions/setup-java from 4.2.1 to 4.2.2 in the github-actions group
  • 6cc8c64 Back to snapshot deps
  • 3c90e0e [maven-release-plugin] prepare for next development iteration
  • 7b9cf20 [maven-release-plugin] prepare release jackson-bom-2.18.0-rc1
  • f2d90ac Prepare for 2.18.0-rc1 release
  • e910a1e Update deps to 2.18.0-rc1-SNAPSHOT
  • b35d27c Merge branch '2.17' into 2.18
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [com.fasterxml.jackson:jackson-bom](https://github.com/FasterXML/jackson-bom) from 2.17.2 to 2.18.0.
- [Commits](FasterXML/jackson-bom@jackson-bom-2.17.2...jackson-bom-2.18.0)

---
updated-dependencies:
- dependency-name: com.fasterxml.jackson:jackson-bom
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the area/dependencies Pull requests that update a dependency file label Oct 1, 2024
@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Oct 1, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 2, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit b2e6181.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
JVM Tests - JDK 17 Build Failures Logs Raw logs 🔍
JVM Tests - JDK 21 Build Failures Logs Raw logs 🔍
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs 🔍

Full information is available in the Build summary check run.
You can consult the Develocity build scans.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/resteasy-reactive/rest-jackson/deployment 
! Skipped: extensions/keycloak-admin-rest-client/deployment extensions/micrometer-registry-prometheus/deployment extensions/micrometer/deployment and 105 more

📦 extensions/resteasy-reactive/rest-jackson/deployment

io.quarkus.resteasy.reactive.jackson.deployment.test.ExceptionInReaderTest.test line 28 - History - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <400> but was <200>.

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)

io.quarkus.resteasy.reactive.jackson.deployment.test.ExceptionInReaderWithCustomMapperTest.test line 34 - History - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <406> but was <200>.

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)

io.quarkus.resteasy.reactive.jackson.deployment.test.ExceptionInReaderWithExcludedBuiltInAndIncludedCustomMapperTest.test line 35 - History - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <999> but was <200>.

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)

⚙️ JVM Tests - JDK 21 #

- Failing: extensions/resteasy-reactive/rest-jackson/deployment 
! Skipped: extensions/keycloak-admin-rest-client/deployment extensions/micrometer-registry-prometheus/deployment extensions/micrometer/deployment and 105 more

📦 extensions/resteasy-reactive/rest-jackson/deployment

io.quarkus.resteasy.reactive.jackson.deployment.test.ExceptionInReaderTest.test line 28 - History - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <400> but was <200>.

	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:73)

io.quarkus.resteasy.reactive.jackson.deployment.test.ExceptionInReaderWithCustomMapperTest.test line 34 - History - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <406> but was <200>.

	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:73)

io.quarkus.resteasy.reactive.jackson.deployment.test.ExceptionInReaderWithExcludedBuiltInAndIncludedCustomMapperTest.test line 35 - History - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <999> but was <200>.

	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:73)

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/resteasy-reactive/rest-jackson/deployment 
! Skipped: extensions/keycloak-admin-rest-client/deployment extensions/micrometer-registry-prometheus/deployment extensions/micrometer/deployment and 105 more

📦 extensions/resteasy-reactive/rest-jackson/deployment

io.quarkus.resteasy.reactive.jackson.deployment.test.ExceptionInReaderTest.test line 28 - History - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <400> but was <200>.

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)

io.quarkus.resteasy.reactive.jackson.deployment.test.ExceptionInReaderWithCustomMapperTest.test line 34 - History - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <406> but was <200>.

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)

io.quarkus.resteasy.reactive.jackson.deployment.test.ExceptionInReaderWithExcludedBuiltInAndIncludedCustomMapperTest.test line 35 - History - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <999> but was <200>.

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)

@geoand
Copy link
Contributor

geoand commented Oct 2, 2024

@mariofusco another one you might be interested in :)

I am assuming that the exception hierarchy changed in Jackson and we need to update our exception mappers.

@mariofusco
Copy link
Contributor

It is expected that Jackson no longer throws an exception and then the rest endpoint invocation now returns a status code of 200 instead of 400, since it is now able to deserialize this object, even if it doesn't have a no-args constructor, as a consequence of this improvement FasterXML/jackson-databind#4515

@geoand @FroMage @gsmet At this point I don't know if those failing tests are still meaningful and if so how they should be modified. Is it just changing that 400 into a 200 acceptable?

@geoand
Copy link
Contributor

geoand commented Oct 2, 2024

Thanks for the input!

I'll have a closer look at those tests tomorrow

@geoand geoand mentioned this pull request Oct 3, 2024
@geoand
Copy link
Contributor

geoand commented Oct 3, 2024

Replaced by #43669

@geoand geoand closed this Oct 3, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 3, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Oct 3, 2024
@dependabot dependabot bot deleted the dependabot/maven/com.fasterxml.jackson-jackson-bom-2.18.0 branch October 3, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants