Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't release IT projects #249

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Don't release IT projects #249

merged 3 commits into from
Nov 6, 2024

Conversation

brunobat
Copy link
Collaborator

@brunobat brunobat commented Nov 6, 2024

No description provided.

@brunobat brunobat requested a review from a team as a code owner November 6, 2024 14:59
@brunobat brunobat requested review from gastaldi and removed request for a team November 6, 2024 14:59
gastaldi
gastaldi requested changes Nov 6, 2024
View reviewed changes
Copy link
Member

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually you need to move that to the parent poms that each integration-test module belongs to

@brunobat
Copy link
Collaborator Author

brunobat commented Nov 6, 2024 •
edited
Loading

ummm... can't I do it like in here:

quarkus-opentelemetry-exporter/quarkus-opentelemetry-exporter-gcp/pom.xml

Line 20 in 0a01b41

<profiles>

I realise the azure one doesn't have that.

@gastaldi
Copy link
Member

gastaldi commented Nov 6, 2024

You need to remove this line:

quarkus-opentelemetry-exporter/quarkus-opentelemetry-exporter-gcp/pom.xml

Line 17 in 0a01b41

<module>integration-tests</module>

gastaldi
gastaldi approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it looks good

@brunobat
Copy link
Collaborator Author

brunobat commented Nov 6, 2024

Nice! many thanks @gastaldi !

@gastaldi gastaldi merged commit 4170aa7 into quarkiverse:main Nov 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brunobat @gastaldi