Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More explicit documentation of endianness #1500

Merged
merged 4 commits into from
Dec 19, 2024

Conversation

mpharrigan
Copy link
Collaborator

This needs to be so explicit in class docstrings, as it is a common source of confusion and error.

@ncrubin

@ncrubin ncrubin self-requested a review December 19, 2024 17:24
Copy link
Collaborator

@ncrubin ncrubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@mhucka mhucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are so straightforward that I can probably offer an approval even though I'm not knowledgeable about Qualtran.

LGTM.

@tanujkhattar tanujkhattar merged commit a0d4d6b into quantumlib:main Dec 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants