Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A couple tiny hotfixes to opsy stuff #222

Merged
merged 34 commits into from
Apr 11, 2022
Merged

A couple tiny hotfixes to opsy stuff #222

merged 34 commits into from
Apr 11, 2022

Conversation

quinn-dougherty
Copy link
Contributor

@quinn-dougherty quinn-dougherty commented Apr 11, 2022 •
edited
Loading

Of import in this PR is that changes to squiggle-lang should have been triggering runs of components and website all along, since they do the squiggle-lang build as a subprocess/prerequisite.

Hazelfire
Hazelfire reviewed Apr 11, 2022
View reviewed changes
@netlify
Copy link

netlify bot commented Apr 11, 2022 •
edited
Loading

✅ Deploy Preview for squiggle-components canceled.

Name Link
🔨 Latest commit a498ed4
🔍 Latest deploy log https://app.netlify.com/sites/squiggle-components/deploys/6254a15250e5f700092e7412

@OAGr
Copy link
Contributor

OAGr commented Apr 11, 2022

This looks fine to me, I'm happy if others here are.

@Hazelfire
Copy link
Collaborator

I'd prefer to see website tested when components changes before merging

@quinn-dougherty
Copy link
Contributor Author

Let's leave it unmerged until tomorrow evening when we have new branching schema figured out. That way we can piggyback any ops changes to it.

@netlify
Copy link

netlify bot commented Apr 11, 2022 •
edited
Loading

✅ Deploy Preview for squiggle-documentation canceled.

Name Link
🔨 Latest commit a498ed4
🔍 Latest deploy log https://app.netlify.com/sites/squiggle-documentation/deploys/6254a152591853000a328c60

@quinn-dougherty quinn-dougherty requested a review from OAGr as a code owner April 11, 2022 04:19
@quinn-dougherty quinn-dougherty force-pushed the quinn-dougherty-patch-1 branch from 23f7f03 to 7c27c0a Compare April 11, 2022 04:25
@quinn-dougherty
Copy link
Contributor Author

Rescript part of #224 is in here.

@quinn-dougherty
Copy link
Contributor Author

This is going to get merged in (later tonight) with lint job failing so as to not create MC with #226

@quinn-dougherty quinn-dougherty mentioned this pull request Apr 11, 2022
Merged
@quinn-dougherty quinn-dougherty changed the base branch from staging to develop April 11, 2022 22:36
@OAGr OAGr changed the base branch from develop to staging April 11, 2022 22:50
@quinn-dougherty quinn-dougherty merged commit 49b9801 into develop Apr 11, 2022
@quinn-dougherty quinn-dougherty deleted the quinn-dougherty-patch-1 branch April 11, 2022 23:21
@quinn-dougherty quinn-dougherty mentioned this pull request Apr 11, 2022
Merged
@berekuk berekuk added the Devops Pertaining to CI and other scripting infra, building and deploying label Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hazelfire Hazelfire Hazelfire left review comments

@OAGr OAGr Awaiting requested review from OAGr

Assignees
No one assigned
Labels
Devops Pertaining to CI and other scripting infra, building and deploying
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@quinn-dougherty @OAGr @Hazelfire @berekuk