Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed question page #88

Merged
merged 2 commits into from
May 31, 2022
Merged

Embed question page #88

merged 2 commits into from
May 31, 2022

Conversation

berekuk
Copy link
Collaborator

@berekuk berekuk commented May 26, 2022

For #77.

@vercel
Copy link

vercel bot commented May 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
metaforecast ✅ Ready (Inspect) Visit Preview May 26, 2022 at 1:15PM (UTC)

@berekuk
Copy link
Collaborator Author

berekuk commented May 26, 2022

(from #77)

Things to consider:

  • Size

Responsive, with recommended 600x600 pixels in html code, which should be enough to fit the chart and options, probably with a scrollbar, but options should fit in a visible area.

  • Caching?

None; I'm not sure if our database will handle the load if someone embeds the chart on >10 rps page, but I think it's ok not to optimize this for now.

  • Customizability?

None. Let's wait for user requests instead of trying to guess.


Discoverability: I added an Embed section on each question's page.

Overall, question page layout is becoming messy, I'm going to experiment a bit with different headings and alignments before merging.

@NunoSempere
Copy link
Collaborator

This is beautiful

@NunoSempere
Copy link
Collaborator

@Claygr, check it out

@NunoSempere
Copy link
Collaborator

NunoSempere commented May 26, 2022

(See also: ForumMagnum/ForumMagnum#4907 and ForumMagnum/ForumMagnum#4728 for how to integrate this with LW)

@berekuk
Copy link
Collaborator Author

berekuk commented May 26, 2022

ForumMagnum/ForumMagnum#4907 and ForumMagnum/ForumMagnum#4907

These links are identical, should one of them be different?

@NunoSempere
Copy link
Collaborator

Yeah, changed

@berekuk
Copy link
Collaborator Author

berekuk commented May 31, 2022

Some updates:

  • moved "capture" and "embed" inside the question card
  • restyled headings
  • capture image is now resizable with re-resizable
  • preview link for embed

(I plan to implement LW embeds and #89 in separate PRs, this one is for embed feature only)

@berekuk
Copy link
Collaborator Author

berekuk commented May 31, 2022

Also: section anchor links, because why not.

@berekuk berekuk merged commit 8fac309 into master May 31, 2022
@berekuk
Copy link
Collaborator Author

berekuk commented May 31, 2022

Oops, my push failed due to rebase and I haven't noticed. Will open a separate PR.

@berekuk berekuk mentioned this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants