Use return impl

quambene · Jan 1, 2024 · ef56a20 · ef56a20
1 parent 0e4c3e0
commit ef56a20
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/cache.rs b/src/cache.rs
@@ -77,7 +77,7 @@ pub trait Caching {
 
     /// Open the cached file for a bookmark.
     // TODO: return `Result<Option<impl Read>, anyhow::Error>` (see <https://github.com/rust-lang/rust/issues/91611>).
-    fn open(&self, bookmark: &TargetBookmark) -> Result<Option<File>, BogrepError>;
+    fn open(&self, bookmark: &TargetBookmark) -> Result<Option<impl Read>, BogrepError>;
 
     /// Get the content of a bookmark from cache.
     // TODO: make get async
@@ -153,7 +153,7 @@ impl Caching for Cache {
         bookmark.cache_modes.contains(self.mode())
     }
 
-    fn open(&self, bookmark: &TargetBookmark) -> Result<Option<File>, BogrepError> {
+    fn open(&self, bookmark: &TargetBookmark) -> Result<Option<impl Read>, BogrepError> {
         let cache_path = self.bookmark_path(&bookmark.id);
         debug!("Open website: {}", cache_path.display());
 
@@ -322,8 +322,8 @@ impl Caching for MockCache {
         self.get(bookmark).unwrap().is_some()
     }
 
-    fn open(&self, _bookmark: &TargetBookmark) -> Result<Option<File>, BogrepError> {
-        Ok(None)
+    fn open(&self, _bookmark: &TargetBookmark) -> Result<Option<impl Read>, BogrepError> {
+        Ok(None::<File>)
     }
 
     fn get(&self, bookmark: &TargetBookmark) -> Result<Option<String>, BogrepError> {