Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correction to index buffer type in loadMeshBVH #5

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Correction to index buffer type in loadMeshBVH #5

wants to merge 1 commit into from

Commits on Mar 14, 2024

  1. Correction to index buffer type in loadMeshBVH 

    Only unsigned integer types are supported for user-supplied meshes in QQuick3DGeometry, and make sense for index buffers in general. The pre-set signed indexBufferFormat was always used in the old code, since "attribute.componentType" (either uint32 or uint16) never matched any of the signed alternatives in the if-clauses. This appears to have worked fine with uint32 buffers, but caused crashes with uint16 (due to out-of-bounds accesses caused by bad casts downstream).
    @santeripuranen
    santeripuranen authored Mar 14, 2024
    Configuration menu
    Copy the full SHA
    00cc67f View commit details
    Browse the repository at this point in the history