Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3532][16.0][IMP] product_plm_import: add purchase_description_rule #52

Merged
merged 6 commits into from
Oct 13, 2023

Conversation

AungKoKoLin1997
Copy link
Contributor

Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rinaldifirdaus Please follow up to update the translation and readme - I realize that there is currently no explanation on PLM-product mapping. Please add a brief explanation on this in CONFIGURE.rst.

Comment on lines 26 to 27
("standard", "Standard Description"),
("plm", "PLM Description"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be more descriptive.

Suggested change
("standard", "Standard Description"),
("plm", "PLM Description"),
("standard", "Standard: [Generic Name] / [Drawing] / [Spec]"),
("generic_name", "Generic Name),

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 3532-akkl-product_plm_import branch from efb7f5b to 5428082 Compare October 11, 2023 09:44
@rinaldifirdaus
Copy link
Contributor

Please follow up to update the translation and readme - I realize that there is currently no explanation on PLM-product mapping. Please add a brief explanation on this in CONFIGURE.rst.

@yostashiro san, i've added the PLM-product mapping on configure file on the new commit.
regarding translations, i've just added the new term that improved on this PR.
there are many term that is not translated yet, i remember that client inform us that message should be in english. is the untranslated term based on this client request or all of this term should be translated?

Thank you

Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@yostashiro yostashiro merged commit aedb0d2 into 16.0 Oct 13, 2023
@yostashiro yostashiro deleted the 3532-akkl-product_plm_import branch April 4, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants