Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][3550][ADD] product_security #48

Merged
merged 4 commits into from
Oct 18, 2023
Merged

Conversation

AungKoKoLin1997
Copy link
Contributor

Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. Please just update the commented part.

@@ -0,0 +1,9 @@
This module restricts the updating of product categories for products to only those users
in the group_product_category_management group.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
in the group_product_category_management group.
in the group_product_manager group.

"You are not allowed to update product category. Please contact administrator"
" as necessary."
msgstr ""
"プロダクトカテゴリーを更新することは許可されていません。"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"プロダクトカテゴリーを更新することは許可されていません"
"プロダクトカテゴリを更新することは許可されていません"

Just in case, can we keep the translation the same as the standard?
Sorry for the detail.

@kanda999 kanda999 merged commit 3776055 into 16.0 Oct 18, 2023
2 checks passed
@yostashiro yostashiro deleted the 16.0-add-product_security branch April 4, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants