Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: run queue #608

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: run queue #608

wants to merge 2 commits into from

Conversation

boandriy
Copy link
Collaborator

added run queue, both on the collection and run now page.
closes #537

@boandriy boandriy self-assigned this Nov 25, 2021
Copy link
Contributor

@chriswhong chriswhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit:

"Waiting" should be capitalized so is looks the same as "Running" and "Success" and "No Changes" when showing run statuses

Merge pull request #599 from qri-io/ab/readme-more
@ramfox
Copy link
Member

ramfox commented Dec 9, 2021

Hey, so examining your PR and taking a look at the backend.

I think the way you are adding the "Waiting" event is a clever way to solve this. But it means that we lose the ability to "cancel" the queued run, because you need the RunID in order to cancel the event. So I took a look at what we were sending over the websocket:

{ 
    // this is the run id
    data: "6ea4d6e2-e145-44e3-b8f2-a8c7988140a9"
    // this is ALSO the run id
    sessionID: "6ea4d6e2-e145-44e3-b8f2-a8c7988140a9"
    ts: 1639068512035200300
    type: "automation:RunQueuePush"
}

This is NOT ENOUGH INFO!!! How are you supposed to relate that run id to the dataset? I keep failing to think of the practical way this is going to be used in the frontend.

So, I'm going to refactor the backend to send over the dataset id (InitID) as well. Let's have a quick meeting tomorrow where we talk about the best way this can work for you in frontend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[workflow]: User can see that a run has been requested but hasn't started (run queue)
3 participants