Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to pass empty variation value to keep param empty #25

Merged
merged 4 commits into from
Apr 22, 2024

Conversation

davidhoelzel
Copy link
Member

@davidhoelzel davidhoelzel commented Apr 19, 2024

When giving a parameter value in a variation as empty string, it will be provided as NULL in component-view:

variations:
  default:
    param1: ''

When the parameter is left out of the variation, it is generated as random fake-data as before.

# Conflicts:
#	src/Component/ComponentItemFactory.php
#	tests/Functional/Service/ComponentItemFactoryTest.php
@davidhoelzel davidhoelzel requested a review from danielaKay April 19, 2024 11:02
@davidhoelzel davidhoelzel merged commit 251bb0a into main Apr 22, 2024
2 checks passed
@davidhoelzel davidhoelzel deleted the issue-23 branch April 25, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants