Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix startup sound for Planck (#8852) #24893

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JunoNgx
Copy link
Contributor

@JunoNgx JunoNgx commented Feb 2, 2025

Description

Add to Planck config to resolve #8852, as suggested by Drashna.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the keymap label Feb 2, 2025
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As audio is enabled at the keyboard level, it would probably be best to enable this at the keyboard level too. keyboards/planck/config.h already has some audio config there, so setting it there should be okay-ish. (and this setting doesn't really hurt the boards that don't need it...)

@JunoNgx
Copy link
Contributor Author

JunoNgx commented Feb 3, 2025

Config moved to keyboards/planck/config.h as suggested by @drashna. Let me know if anything else should be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants