Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix JSON syntax for #24527 (data/constants/keycodes) #24528

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ngrigoriev
Copy link

Minor JSON syntax fixes (extra or missing commas).

Description

A couple of files have extra or missing commas that prevent them from being valid JSON ones.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • 24527

Checklist

  • [ n/a ] My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • [ n/a ] I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the dd Data Driven Changes label Oct 25, 2024
@zvecr
Copy link
Member

zvecr commented Oct 25, 2024

that prevent them from being valid JSON ones.

The files are hjson and not json. The format isnt as strict, and allows content such as comments. Content that would fail most json parsers.

If you need json, then you should be consuming the converted files from the API endpoint (For example https://keyboards.qmk.fm/v1/constants/keycodes_0.0.1.json).

This includes any processing that happens with merging content, avoiding the consuming process having to duplicate any of the lib/python logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dd Data Driven Changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants