Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Riverflow matrix effect with runner #24520

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

filterpaper
Copy link
Contributor

@filterpaper filterpaper commented Oct 24, 2024

Description

Simplify effect by reusing an existing runner

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team October 25, 2024 02:40
@filterpaper filterpaper force-pushed the riverflow-refactor branch 2 times, most recently from c7e8682 to 57018b1 Compare October 25, 2024 07:07
Simplify effect by reusing an existing runner
@filterpaper filterpaper changed the title Refactor Riverflow matrix effect Refactor Riverflow matrix effect with runner Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants