Support select ... where foo = true #592
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i.e. filtering by the boolean value true, rather than the string 'true'
| @@ -96,14 +105,14 @@ function _iterate(resource, statement, context, source, keep) { | |||
| for(var v in result) { | |||
| if(_.isArray(expected[j])) { | |||
| for(var vv in expected[j]) { | |||
| if(result[v] == expected[j][vv]) { | |||
| if(result[v] === expected[j][vv]) { | |||
There was a problem hiding this comment.
This change is necessary to prevent the boolean true matching 0, etc. This does, however, mean that queries that previously relied upon '' matching 0 will break, but arguably it was a bug that they matched in the first place...
The alternative is to check whether the expected value is a boolean, and only doing the stricter === check if so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is, filtering by the boolean value
true, rather than the string'true'.