fix: update unicorn preset to 56, update prettier to v3 #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimonka83
approved these changes
Oct 10, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
antongolub
force-pushed
the
unicorn-56
branch
2 times, most recently
from
7e647dc
to
aef2438
Compare
antongolub
changed the title
antongolub
force-pushed
the
unicorn-56
branch
from
aef2438
to
07b9fe4
Compare
antongolub
force-pushed
the
unicorn-56
branch
3 times, most recently
from
5441908
to
438defb
Compare
antongolub
force-pushed
the
unicorn-56
branch
from
438defb
to
e39cc51
Compare
BREAKING CHANGE: prettier v3
antongolub
force-pushed
the
unicorn-56
branch
from
e39cc51
to
b2935bf
Compare
|
|
||
| expect(readFileSync(temp, 'utf-8')).toBe(readFileSync(output, 'utf-8')) | ||
| const result = cp.execSync(`${bin} ${input} --config ${configPath}`).toString() |
Check warning
Code scanning / CodeQL
Shell command built from environment values Medium test
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI about 1 month ago
To fix the problem, we should avoid constructing the shell command as a single string and instead use the cp.execFileSync method, which allows us to pass the command and its arguments separately. This approach prevents the shell from interpreting special characters in the paths.
- Replace the
cp.execSynccall withcp.execFileSync. - Pass the command (
bin) and its arguments (input,--config,configPath) as separate parameters tocp.execFileSync.
Suggested changeset
1
packages/prettier-config-qiwi/src/test/ts/index.ts
| @@ -19,3 +19,3 @@ | ||
|
|
||
| const result = cp.execSync(`${bin} ${input} --config ${configPath}`).toString() | ||
| const result = cp.execFileSync(bin, [input, '--config', configPath]).toString() | ||
| expect(result).toBe(fs.readFileSync(output, 'utf-8')) |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #245
closes #225
sindresorhus/eslint-plugin-unicorn@v47.0.0...v56.0.0